feat: Add osxSign.continueOnError option
#1579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! Here are some highlighted action items that will help get it across the finish line, from the
Development and triage is community-driven, so please be patient and we will get back to you as soon as we can. |
futpib
force-pushed
the
osxSign-continueOnError
branch
from
793c041 to
037a77b
Compare
Codecov Report
@@ Coverage Diff @@
## main #1579 +/- ##
==========================================
+ Coverage 95.58% 95.73% +0.14%
==========================================
Files 15 15
Lines 793 797 +4
==========================================
+ Hits 758 763 +5
+ Misses 35 34 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
futpib
force-pushed
the
osxSign-continueOnError
branch
2 times, most recently
from
8567d21 to
454a530
Compare
futpib
force-pushed
the
osxSign-continueOnError
branch
from
454a530 to
646279f
Compare
futpib
changed the title
osxSign.continueOnError optionosxSign.continueOnError option
erikian
approved these changes
Oct 23, 2023
felixrieseberg
approved these changes
Oct 25, 2023
|
Thanks for your contribution! 🎉 |
|
🎉 This PR is included in version 18.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize your changes:
Currently there is no way to know that signing on osx failed other than reading the output. This adds an option
continueOnError(defaults to current behavior,true) one can set to fail the build if there was an error while signing the app.