Version info added to the final executable using rcedit

[Rameshv]

This PR fixes the following issue Set product name, file description copyright on Windows
#30

As per the comment #30 (comment) by @felicienfrancois, rcedit is already doing it.

This patch has following changes

• User need to pass version-string hash in the options. THis has following fields

                   CompanyName
                   LegalCopyright
                   FileDescription
                   OriginalFilename
                   FileVersion
                   ProductVersion
                   ProductName
                   InternalName

• instead of passing just the icon to rcedit, now the version-string is also passed.

Below the sample grunt config

   electron:{
    win : {
      options: {
        name : 'Fresenius',
        dir : 'build/',
        out : 'package/app/win32',
        version : '0.25.3',
        platform: 'win32',
        arch : 'x64',
        icon : 'app/static/assets/icon.ico',
        'version-string': {
          'CompanyName': 'Pocketworks UK.',
          'LegalCopyright': 'Copyright 2015 Pocketworks UK. All rights reserved."',
          'FileDescription' : 'Fresenius',
          'OriginalFilename' : 'Fresenius.exe',
          'FileVersion' : '0.0.1',
          'ProductVersion' : '0.0.1',
          'ProductName' : 'Fresenius',
          'InternalName' : 'Fresenius.exe'
        }
      }
    }
  },

We dont need resourcehacker dependency after all..

Below screenshot is the output of above config.

[malept]

You're going to want to rebase this into one commit.

[Rameshv]

Done @malept

[malept]

More consistent description, IMO:

should contain a hash of the application metadata to be embedded into the executable (Windows only). Keys supported:

Opinions on whether the keys should be prefixed with * or - to visually indicate a list?

[Rameshv]

Yep @malept your message is more appropriate. And i think - is suitable for list.

Also i can make a pull to https://github.com/sindresorhus/grunt-electron on how to specify the hash. That will be easier

[Rameshv]

Companion pr made to the grunt-electron sindresorhus/grunt-electron#2 with updated readme on how to use the version-string in grunt config

[junosuarez]

Hmm, it's not working on my machine:

electron-packager @ d2a2f05
win32 8.1 x64

[junosuarez]

Also: how do we want to handle platform-specific options? Are there any of these properties which overlap on other platforms so we can avoid duplicate config? /cc @maxogden

[Rameshv]

hey @jden i think i got the issue. if there is no icon specified, it skips the entire rcedit call.

      if (!opts.icon) {
        return cb(null, finalPath)
      }

i ll fix it and push in few..

[kfranqueiro]

Is this supposed to be usable via command-line arguments? If it requires a hash, I'm not sure how that's possible...

[Rameshv]

hi @kfranqueiro it is possible to use this with command line arguments too. packager uses minimist which parses the hashes too. You can do this way

electron-packager|versionedit ✗⇒ 
node example.js --name=Test --dir='out' --version-string.CompanyName=pocketworks --version-string.LegalCopyright='Copyright 2015 Pocketworks UK. All rights reserved.'
{ _: [],
  name: 'Test',
  dir: 'out',
  'version-string': 
   { CompanyName: 'pocketworks',
     LegalCopyright: 'Copyright 2015 Pocketworks UK. All rights reserved.' } }

[alexwarren]

Looks like FileVersion is being ignored? It's not updating for me, and I can see in the screenshot for this PR that it's not updated there either.

[kfranqueiro]

I noticed this as well, and was wondering if it's actually an issue with rcedit.

[Rameshv]

@alexwarren @kfranqueiro FileVersion is the correct property metadata name. I just verified it in an exe with the resource hacker. Yep it seems like the issue is with rcedit