Skip to content

Update EASTL_Project_Integration.md #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PetiteViking
Copy link

Some info for building with CMake was outdated.

  • Adding the subdirectory will set up include paths for the packages. No need to do it explicitly.
  • Set include directory per target.
  • EASTL_LIBRARY is now called EASTL.
  • Two new operator overloads are required.

Some info for building with CMake was outdated.
@grojo-ea
Copy link
Contributor

grojo-ea commented Jul 7, 2023

Hello,

Thanks for updating these!

The change looks good to me. Could you please fill out our CLA form with your info so we can merge this change?

@PetiteViking
Copy link
Author

Done!

@vchuynh
Copy link

vchuynh commented Jul 8, 2025

Followed your updated integration guide and got EASTL to build with a couple issues. For the target_link_libraries part, shouldn't it just be EASTL? That's what I needed to do for mine to build. The EASTL variable isn't defined and was failing to build because of it. Also, it might be helpful to note that EASTL will build as a dynamic library if BUILD_SHARED_LIBS is set to true and will throw a link error because it can't find the EASTL.lib file. Somehow mine got set so I had to explicitly add STATIC to the add_library() line in EASTL's cmakelists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants