Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Période : améliorer encore l'affichage lorsque cycle_type n'est pas défini #961

Merged
merged 3 commits into from
Aug 23, 2023

Conversation

raphodn
Copy link
Member

@raphodn raphodn commented Aug 23, 2023

Suite de #933

Quoi ?

  • migration pour rendre PeriodPosition.weekCycle nullable (dans le cas de cyle_type: null)
  • cacher les endroits restants où "Semaine" s'affichait (Period edit en particulier)
  • refactoring de PeriodPosition edit collapsible (pour avoir le même rendu partout)

Captures d'écran

Avant Après
Period edit (cycle_type: null) image image

@raphodn raphodn self-assigned this Aug 23, 2023
@raphodn raphodn linked an issue Aug 23, 2023 that may be closed by this pull request
@raphodn raphodn merged commit 40ad512 into master Aug 23, 2023
1 check failed
@raphodn raphodn deleted the raphodn/cycle-type-null-2 branch August 23, 2023 18:43
OursDesCavernes pushed a commit to Les400Coop/gestion-compte that referenced this pull request Jan 20, 2024
…éfini (elefan-grenoble#961)

* Period: hide Semaine title

* Allow PeriodPosition weekCycle field to be null

* Common template for PeriodPosition edit collapsible
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edition d'un créneau type & cycle_type : null
1 participant