Build Docker image on slim base #3204
Conversation
|
Can we track what tests we did with the slim-base to make sure its not breaking anything.
|
For Playwright end-to-end tests in CI, instead of running a development webserver with `yarn dev`, build and deploy a Docker container for Element Call and use that as the webserver to test against.
There weren't any existing tests that used Docker, so I added 073baca to run the Playwright tests against a freshly-built Docker container of EC. This should ensure that not only does the Docker image build properly, but that running containers can successfully serve EC. |
playwright/fixtures/widget-user.ts
Outdated
| "Developer.elementCallUrl", | ||
| null, | ||
| "device", | ||
| "https://localhost:3000/room", |
There was a problem hiding this comment.
For some reason, this wasn't able to use a variable, so I've defined two different versions of the function for each value of the URL.
|
Not sure why the end-to-end tests are hanging in CI, and they run properly for me in an Ubuntu VM... |
|
@AndrewFerr they are currently broken. |
|
I noticed "playwright" in some recent commit messages, so here's a merge to try tests again 🙂 EDIT: Still no luck. |
fkwp
added
the
PR-Improvement
When using a containerized webserver, this stops the container once tests finish.
|
Now we're getting somewhere. Increasing the test job timeout revealed the errors that the tests are hitting, which do not reproduce when running them in a local Ubuntu VM. The tests are failing on expected page elements not being visible. Any idea what could be causing that? |
This reverts commit 298aced. The point of this was to figure out why the tests were being cancelled.
This reduces the size of the runtime image by about 50%.
depends on #3294