Never hide media from your own user #29797
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t3chguy
requested changes
Apr 22, 2025
| @@ -19,14 +19,15 @@ const PRIVATE_JOIN_RULES: JoinRule[] = [JoinRule.Invite, JoinRule.Knock, JoinRul | |||
|
|
|||
| /** | |||
| * Should the media event be visible in the client, or hidden. | |||
| * @param eventId The eventId of the media event. | |||
There was a problem hiding this comment.
Can we improve docs rather than make them worse? Notably would be good to document the behaviour if mxEvent === undefined
There was a problem hiding this comment.
Hopefully vastly improved.
|
(Converting to draft until I have dealt with failing tests) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small extension onto #29582
This ensures that media from your own userID is always shown, which prevents having to always click to show after uploading media. We trust media from our own user always.
Checklist
public/exportedsymbols have accurate TSDoc documentation.