Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uploadRoomKeysToBackup: Use V3 route #1184

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

NicolaiSoeborg
Copy link
Contributor

Fixes #741

"Tested" locally by rewriting r0 to v3 in reverse proxy (Caddy) and seeing All keys are backed up. instead of repeated failing PUT requests towards Conduit (home server)

matrix.example.com {
    rewrite /_matrix/client/r0/room_keys/keys /_matrix/client/v3/room_keys/keys?{query}
    reverse_proxy /_matrix/* localhost:8448
}

Signed-off-by: Nicolai Søborg [email protected]

Fixes element-hq#741

"Tested" locally by rewriting `r0` to `v3` in reverse proxy (Caddy) and seeing `All keys are backed up.` instead of repeated failing PUT requests towards Conduit (home server)

```
matrix.example.com {
    rewrite /_matrix/client/r0/room_keys/keys /_matrix/client/v3/room_keys/keys?{query}
    reverse_proxy /_matrix/* localhost:8448
}
```

Signed-off-by: Nicolai Søborg <[email protected]>
Copy link
Member

@MidhunSureshR MidhunSureshR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 💯

@MidhunSureshR MidhunSureshR merged commit 3803386 into element-hq:master Aug 30, 2024
2 checks passed
@NicolaiSoeborg NicolaiSoeborg deleted the patch-1 branch October 29, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PUT /_matrix/client/r0/room_keys/keys is used, while it was never specced.
2 participants