Add max_portal_remote_users, optionally refusing to join too big Telegram rooms #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gram rooms This still (currently) allows them to organically grow beyond the limit later.
jaywink
reviewed
Oct 28, 2021
| @@ -221,6 +221,8 @@ bridge: | |||
| # The maximum number of rooms that can be bridged on this instance. | |||
| # When the maximum number of rooms has been reached, attempts to create new links will error. Set to -1 to disable. | |||
| max_portal_rooms: -1 | |||
| # The maximum number of Telegram users allowed in a single room | |||
There was a problem hiding this comment.
Set to -1 to disable. might be a nice addition to the documentation, like above.
Thought technically, 0 will also disable, which is a bit weird, but I suppose that is how the code is written here in general?
| async def get_remote_user_count(self, user: 'u.User') -> int: | ||
| entity = await self.get_entity(user) | ||
| if not isinstance(entity, (Chat, Channel)): | ||
| raise ValueError("Can't get remote user count for Portal that isn't Chat nor Channel") |
There was a problem hiding this comment.
Should we not catch this as it could crash a bridging attempt? What other entities are there?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This still (currently) allows them to organically grow beyond the limit later.
Addresses mautrix#672