Ele 4774 update tests quality dimension

[NoyaArie]

Summary by CodeRabbit

• Chores
  • Updated test configurations to include or correct the "quality_dimension" attribute for improved classification of data quality tests. No changes to test behavior or user interface.

[linear]

ELE-4774 quality dimension for tests

[coderabbitai]

Walkthrough

The update modifies the internal test configuration mapping within the common_test_configs.sql macro by assigning or correcting the "quality_dimension" attribute for various test types. No function signatures or exported entities were changed; only the metadata for test configurations was updated to include or adjust their quality dimension classification.

Changes

File(s)	Change Summary
macros/utils/common_test_configs.sql	Added or corrected the "quality_dimension" attribute for multiple test configurations within the macro's returned mapping. No changes to macro signatures or exported functionality.

Poem

In the warren of tests, a new order is found,
With "quality_dimension" now clearly renowned.
Validity, accuracy, completeness—each with a name,
Freshness and more, now part of the game.
A hop, a skip, through configs anew—
This rabbit ensures our data stays true! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5e4842d and eb3d6e8.

📒 Files selected for processing (1)

• macros/utils/common_test_configs.sql (6 hunks)

🧰 Additional context used

🧠 Learnings (1)

macros/utils/common_test_configs.sql (1)

Learnt from: haritamar
PR: elementary-data/dbt-data-reliability#825
File: integration_tests/dbt_project/models/exposures.yml:39-44
Timestamp: 2025-07-15T19:30:40.238Z
Learning: In dbt exposures, metadata should be defined under `config.meta` not directly under `meta`. The correct schema for exposures is to nest the meta field under config according to official dbt documentation.

🔇 Additional comments (13)

macros/utils/common_test_configs.sql (13)

171-174: Quality dimension correctly added for expect_column_to_exist.

The "validity" classification aligns with industry-standard definitions and the syntax is sound (comma placement and closing brace).

---

224-226: Please double-check the dimension chosen for expect_table_row_count_to_equal.

Row-count equality can reasonably map to either completeness (all expected rows exist) or accuracy/consistency (numerical correctness). If your internal taxonomy explicitly places it under completeness, no change is needed—otherwise consider revising.

---

232-234: Good metadata enrichment for expect_column_values_to_be_in_type_list.

The validity tag is appropriate and keeps the file consistent.

---

312-314: Accurate classification for moving-stdev anomaly test.

Labeling this statistical outlier check as accuracy is spot-on.

---

316-318: Accurate classification for fixed-stdev anomaly test.

Same remark as above—classification and syntax look good.

---

320-322: Completeness dimension makes sense for expect_row_values_to_have_data_for_every_n_datepart.

No issues spotted.

---

408-410: schema_changes → validity : looks correct.

Tracking schema drift is a validity concern; change approved.

---

412-414: schema_changes_from_baseline correctly tagged as validity.

Syntax and placement are fine.

---

421-423: volume_anomalies rightly mapped to completeness.

No further action required.

---

425-427: freshness_anomalies tagged as freshness — obvious but important.

Looks good.

---

429-431: event_freshness_anomalies also under freshness — consistent.

Implementation detail is fine.

---

433-435: dimension_anomalies → completeness : sensible choice.

Metadata addition LGTM.

---

443-445: exposure_schema_validity now carries the validity tag — good catch.

This fills an obvious gap in the mapping.

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

👋 @NoyaArie
Thank you for raising your pull request.
Please make sure to add tests and document all user-facing changes.
You can do this by editing the docs files in the elementary repository.