Conversation
Co-Authored-By: Itamar Hartstein <haritamar@gmail.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
👋 @devin-ai-integration[bot] |
|
No actionable comments were generated in the recent review. 🎉 📝 WalkthroughWalkthroughThe pull request disables Redshift testing in the GitHub Actions test-all-warehouses workflow by removing it from the test matrix and adding comments explaining the temporary disable due to Fusion SVV_COLUMNS resolution issues. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Comment |
The SVV_COLUMNS lookup failure is not version-specific (same on preview.119 and .120). Setting static_analysis: off at the project level may prevent Fusion from using the sidecar for adapter.get_columns_in_relation() calls, falling back to direct DB introspection instead. Co-Authored-By: Itamar Hartstein <haritamar@gmail.com>
…MNS bug Fusion's sidecar adapter cannot resolve source schemas via SVV_COLUMNS on Redshift, causing adapter.get_columns_in_relation() to return empty. This is a Fusion-side bug (not version-specific - confirmed on both preview.119 and preview.120). Also reverts the static_analysis: off attempt which had no effect. Tested approaches that did NOT fix the issue: - Pinning to preview.119 - Setting static_analysis: off in dbt_project.yml Related dbt-fusion issues: #615, #747, #1304, #1316 Co-Authored-By: Itamar Hartstein <haritamar@gmail.com>
ci: temporarily disable fusion/redshift tests (Fusion sidecar SVV_COLUMNS bug)
Summary
Temporarily removes the
fusion/redshiftentry from the CI test matrix. Fusion's sidecar adapter cannot resolve source schemas via Redshift'sSVV_COLUMNS, causingadapter.get_columns_in_relation()to return empty and 92 of 167 tests to fail with compilation errors.This is a Fusion-side bug, not something fixable in elementary. Confirmed by testing two approaches that had no effect:
preview.119— same 92 failures (the bug predatespreview.120)static_analysis: offindbt_project.yml— same 92 failures (the sidecar still returns empty)Validated facts (from CI logs)
dbt1014: Failed to download source schema ... No schema in SVV_COLUMNS for <database>.<schema>.<table>— tables DO exist (created bydbt seedimmediately beforedbt test).dbt1501(26×, Jinja column resolution fails) anddbt1308(62×, SQL PREPARE fails because relation not found by sidecar).preview.119andpreview.120.Related dbt-fusion issues
output.parquetbaselinemode produces empty CTE fromadapter.get_columns_in_relation()Review & Testing Checklist for Human
fusion/redshiftin the CI matrix once the upstream fix lands.Notes