feat: add dremio__target_database dispatch macro#952
Conversation
Co-Authored-By: Itamar Hartstein <[email protected]>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
👋 @devin-ai-integration[bot] |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: defaults Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdded a new Jinja macro Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Summary
Adds a
dremio__target_database()dispatch macro so the elementary package can correctly resolve the target database when running against a Dremio adapter. Without this, the default dispatch (target.dbname) is used, which isUndefinedfor Dremio — Dremio profiles usedatabasefor the catalog/space name.Review & Testing Checklist for Human
target.databaseis the correct profile property for dbt-dremio (Dremio profiles definedatabaseas the catalog/space name)Notes
Summary by CodeRabbit