Skip to content

feat: add dremio__target_database dispatch macro#952

Merged
haritamar merged 1 commit intomasterfrom
devin/1772460163-add-dremio-target-database
Mar 2, 2026
Merged

feat: add dremio__target_database dispatch macro#952
haritamar merged 1 commit intomasterfrom
devin/1772460163-add-dremio-target-database

Conversation

@devin-ai-integration
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Mar 2, 2026

Summary

Adds a dremio__target_database() dispatch macro so the elementary package can correctly resolve the target database when running against a Dremio adapter. Without this, the default dispatch (target.dbname) is used, which is Undefined for Dremio — Dremio profiles use database for the catalog/space name.

Review & Testing Checklist for Human

  • Verify that target.database is the correct profile property for dbt-dremio (Dremio profiles define database as the catalog/space name)
  • Confirm no other Dremio-specific dispatches are missing in cross_db_utils

Notes

Summary by CodeRabbit

  • New Features
    • Added support for Dremio as a target database option, enabling users to configure and utilize Dremio in their database workflows and operations.

@devin-ai-integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2026

👋 @devin-ai-integration[bot]
Thank you for raising your pull request.
Please make sure to add tests and document all user-facing changes.
You can do this by editing the docs files in the elementary repository.

@coderabbitai
Copy link

coderabbitai bot commented Mar 2, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 66ad06a and 785a0d8.

📒 Files selected for processing (1)
  • macros/utils/cross_db_utils/target_database.sql

📝 Walkthrough

Walkthrough

Added a new Jinja macro dremio__target_database() that returns target.database for Dremio database support, following the established pattern of similar database-specific macros across the codebase.

Changes

Cohort / File(s) Summary
Dremio Database Macro
macros/utils/cross_db_utils/target_database.sql
Added new dremio__target_database() macro that returns target.database, extending existing database-specific macro patterns to support Dremio.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A macro for Dremio, simple and bright,
Returns target.database, just right!
Following patterns, consistent and clean,
Database support, now pristine. ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately describes the main change: adding a dremio__target_database dispatch macro, which is the primary purpose of this PR.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch devin/1772460163-add-dremio-target-database

Comment @coderabbitai help to get the list of available commands and usage tips.

@haritamar haritamar merged commit 9e7ed76 into master Mar 2, 2026
25 checks passed
@haritamar haritamar deleted the devin/1772460163-add-dremio-target-database branch March 2, 2026 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant