Mika via Elementary: Optimize marketing_ads model for performance and maintainability #398
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR optimizes the
marketing_ads
model with several improvements:Replaced
SELECT *
with explicit column selectionAdded proper incremental logic
{% if is_incremental() %}
filters to each CTE to only process new recordsFixed column naming
utm_campain
typo toutm_campaign
Restructured SQL for readability
These changes maintain the same functionality while improving performance and maintainability.
Created by:
[email protected]