Mika via Elementary: Fix historical_orders model to convert monetary values from cents to dollars #400
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an inconsistency in how monetary values are handled between
historical_orders
andreal_time_orders
models.Issue
real_time_orders
model correctly converts monetary values from cents to dollars using thecents_to_dollars
macrohistorical_orders
model was not applying this conversion, leaving values in centsreturn_on_advertising_spend
calculationsChanges
cents_to_dollars
conversion to all monetary fields inhistorical_orders
modelreal_time_orders
model to document that values are in dollarsThis should resolve the anomalies detected in the
cpa_and_roas
model's ROAS metrics.Created by:
[email protected]