Joost Boonzajer Flaes via Elementary: Fix unit mismatch between historical_orders and real_time_orders

[joostboon]

Description

This PR fixes a critical unit mismatch between the historical_orders and real_time_orders models that was causing anomalies in the RETURN_ON_ADVERTISING_SPEND metric.

Problem

• real_time_orders: Uses the cents_to_dollars macro to convert amounts to dollars
• historical_orders: Passes through amounts in cents without conversion

This resulted in a ~100× scale difference in the data feeding into downstream models, causing the ROAS calculation to be inconsistent.

Changes

1. Modified historical_orders.sql to:

   • Rename the amount column to amount_cents for clarity
   • Apply the cents_to_dollars macro to all monetary values
   • Use consistent formatting with real_time_orders

2. Added documentation comment to real_time_orders.sql to clarify that all monetary values are in dollars

Impact

This fix will normalize all monetary values across the pipeline, ensuring that calculations like ROAS are consistent regardless of whether the data comes from historical or real-time sources.

Created by: [email protected]