Smooth switch between dark and light styles #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just a suggestion :) The dock adapts in a smooth manner when changing style in system settings: slowly gets darker if switch to dark, slowly gets lighter if switch to light the animation follows the same as wingpanel becoming opaque - and as in several places in the stylesheet the animation is slower than wingpanel - as that one is too short and like current behaviour: immediate blink. I would go with slower here because the user is being eased in to the new colour - It is not the same context and intent as the interface adapting to a change
|
i summon @elementary/desktop-developers ! |
danirabbit
requested changes
Jan 31, 2025
| @@ -5,6 +5,7 @@ | |||
|
|
|||
| dock { | |||
| background: @bg_color; | |||
| transition: background 800ms cubic-bezier(0.4, 0, 0.2, 1); | |||
There was a problem hiding this comment.
Probably should also transition box-shadow
There was a problem hiding this comment.
same effect ?
how is the duration for you ?
i would like to suggest the same transition for the rest of eOS stylesheet, but i yet am not sure yet how to target the components efficiently so as to avoid having the transitions at any other time than when switching style
in a later PR probably.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a suggestion :)
The dock adapts in a smooth manner when changing style in system settings: slowly gets darker if switch to dark, slowly gets lighter if switch to light the animation follows the same as wingpanel becoming opaque - and as in several places in the stylesheet
the animation is slower than wingpanel - as that one is too short and like current behaviour: immediate blink. I would go with slower here because the user is being eased in to the new colour - It is not the same context and intent as the interface adapting to a change