Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to GTK 4 #200

Merged
merged 37 commits into from
Jan 5, 2024
Merged

Port to GTK 4 #200

merged 37 commits into from
Jan 5, 2024

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented Oct 16, 2023

No description provided.

@danirabbit danirabbit changed the title Start porting to GTK 4 Port to GTK 4 Nov 9, 2023
@danirabbit danirabbit marked this pull request as ready for review January 3, 2024 20:15
@danirabbit danirabbit requested a review from a team January 3, 2024 20:15
Copy link
Collaborator

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compiles and runs as expected. There is a bug in that the autologin_switch does not sync with the setting on opening but that is present in master also.

I trust that you will sort out the CI and branch name when appropriate.

@danirabbit
Copy link
Member Author

@jeremypw thank you! If that sync issue isn't already reported can you open a report please?

@danirabbit danirabbit merged commit 7366131 into master Jan 5, 2024
@danirabbit danirabbit deleted the danirabbit/gtk4 branch January 5, 2024 17:08
@jeremypw
Copy link
Collaborator

jeremypw commented Jan 5, 2024

@danirabbit I think it is already reported in #94.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants