Stripped file and gnu_debuglink support take 2 #596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Addressed the first thing. |
|
Removed the FIXME |
eliben
reviewed
Feb 15, 2025
|
Addressed. |
|
@io-no: sorry, I broke your API. If you update to the latest master and/or the next release, linked DWARF retrieval is different, and the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #594, amends PR #525.
#525 treats external DWARF as a special case of supplementary DWARF, which I think is conceptually wrong. This one will provide both an interface for consumers who would prefer to resolve links by hand, and a seamless DWARF retrieval via
ELFFile.load_from_file().Additionally, this PR validates the checksum on the linked DWARF.
Linking by build ID, as outlined at https://sourceware.org/gdb/current/onlinedocs/gdb.html/Separate-Debug-Files.html , is not supported.