_make_gnu_versym_section: {str -> sym}tab #603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Class `GNUVerSymSection` has an associated `SymbolTableSection` that's passed in the constructor, but in `_make_gnu_versym_section()` the variables are named `linked_strtab_index` and `strtab_section`. Rename them to `…_symtab_…` as with all the other cases. Also use the helper method `_get_linked_symtab_section()` which also checks the type for correctness compared to plain `get_section()` introduced later by 9257a0f ("Exceptions on malformed ELF header contents (eliben#552)"). Fixes: 7b24670 ("added support for version definition, version dependency and version symbol sections in pyelftools and readelf.py") Signed-off-by: Philipp Hahn <[email protected]>
eliben
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Class
GNUVerSymSectionhas an associatedSymbolTableSectionthat's passed in the constructor, but in_make_gnu_versym_section()the variables are namedlinked_strtab_indexandstrtab_section. Rename them to…_symtab_…as with all the other cases.Also use the helper method
_get_linked_symtab_section()which also checks the type for correctness compared to plainget_section()introduced later by 9257a0f ("Exceptions on malformed ELF header contents (#552)").Fixes: 7b24670 ("added support for version definition, version dependency and version symbol sections in pyelftools and readelf.py")
Found while working on #514