Merged
Conversation
264fbca to
1397945
Compare
1397945 to
97ba819
Compare
feat(graalvm-js): add new `graalvm-js` module for graaljs integration feat(graalvm-js): initial structure and api for elide's import router feat(graalvm-js): implement commonjs module loading support feat(graalvm-js): implement esm module loading support feat(graalvm-ts): move js realm patcher to `graalvm-js` module feat(graalvm-ts): use new delegated module facilities feat(graalvm): initialize javascript when plugin is added feat(graalvm): enable `node:assert` for injection feat(graalvm): enable `node:path` for injection feat(graalvm): enable `node:zlib` for injection feat(graalvm): enable `node:os` for injection chore: reintroduce graalvm/graaljs modules and pins chore: mark js realm patcher as deprecated test: add test scripts for node paths Signed-off-by: Sam Gammon <[email protected]>
97ba819 to
d06cae3
Compare
Dario Valdespino (darvld)
approved these changes
Feb 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Third revision of a dynamic ability to create synthetic JavaScript modules; the first two approaches proved brittle (bytecode hacks and an overridden JS language implementation, respectively). Instead, this approach involves forking and PR-ing up to GraalJs upstream with an actual proposed feature for JavaScript module import hooks.
Supersedes #1220.
Patch to GraalJs:
Changes
JSModuleLoaderFactoryinterface, which can be implemented by consumersJSEnginejs.module-loader-factory, which can be either"default"or"handler"js.module-loader-factorywhen activeJSRealmcall intoJSEnginewhen lazily creating aJSModuleLoaderProxyObjectcompat)node:assertnode:pathnode:osnode:zlibChangelog