Skip to content

Conversation

@ElijahKotyluk
Copy link
Collaborator

@ElijahKotyluk ElijahKotyluk commented Nov 18, 2025

Ready for review Powered by Pull Request Badge

Summary

Implements randomInt method for Elide's Node.js crypto module.

  • feat: task list here

Changelog

  • feat(cli): added a thing
  • fix(dev): fixed a thing
  • chore: updated → 1.0

@sgammon sgammon changed the title Feat/crypto random int feat(node): crypto.randomInt Nov 18, 2025
@sgammon sgammon added feature Large PRs or issues with full-blown features lang:javascript Issues relating to JavaScript api:node Node API and stdlib tc:winter WinterTC Spec labels Nov 18, 2025
@sgammon sgammon added this to Elide Nov 18, 2025
@sgammon sgammon added the 🚧 WIP Works-in-progress. Blocks merge label Nov 18, 2025
@sgammon sgammon moved this to In Progress in Elide Nov 18, 2025
@sgammon sgammon added this to the Release R18: Beta milestone Nov 18, 2025
@ElijahKotyluk ElijahKotyluk force-pushed the feat/crypto-random-int branch 2 times, most recently from 2184bc4 to f7e2bd3 Compare November 20, 2025 00:59
@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

❌ Patch coverage is 65.62500% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 42.69%. Comparing base (d6e5b1c) to head (debdd00).

Files with missing lines Patch % Lines
...ain/kotlin/elide/runtime/node/crypto/NodeCrypto.kt 65.62% 13 Missing and 9 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1770      +/-   ##
==========================================
+ Coverage   42.64%   42.69%   +0.05%     
==========================================
  Files         897      897              
  Lines       38473    38537      +64     
  Branches     5989     6006      +17     
==========================================
+ Hits        16405    16455      +50     
- Misses      19845    19850       +5     
- Partials     2223     2232       +9     
Flag Coverage Δ
jvm 42.69% <65.62%> (+0.05%) ⬆️
lib 42.69% <65.62%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ternals/intrinsics/js/crypto/WebCryptoIntrinsic.kt 77.50% <ø> (ø)
...tlin/elide/runtime/intrinsics/js/node/CryptoAPI.kt 0.00% <ø> (ø)
...ain/kotlin/elide/runtime/node/crypto/NodeCrypto.kt 71.25% <65.62%> (-16.25%) ⬇️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6e5b1c...debdd00. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ElijahKotyluk ElijahKotyluk marked this pull request as ready for review November 24, 2025 22:41
Elijah Kotyluk-Butler added 13 commits November 25, 2025 20:38
…ated by caching the variable.

Signed-off-by: Elijah Kotyluk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api:node Node API and stdlib feature Large PRs or issues with full-blown features lang:javascript Issues relating to JavaScript tc:winter WinterTC Spec 🚧 WIP Works-in-progress. Blocks merge

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

3 participants