-
Notifications
You must be signed in to change notification settings - Fork 31
feat(node): crypto.createHash
#1779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1779 +/- ##
==========================================
+ Coverage 42.64% 42.67% +0.03%
==========================================
Files 897 898 +1
Lines 38473 38534 +61
Branches 5989 6005 +16
==========================================
+ Hits 16405 16444 +39
- Misses 19845 19860 +15
- Partials 2223 2230 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
crypto.createHash
c556a88 to
5aeee8c
Compare
Signed-off-by: Elijah Kotyluk <[email protected]>
Signed-off-by: Elijah Kotyluk <[email protected]>
Signed-off-by: Elijah Kotyluk <[email protected]>
- Allow digest() to be invoked with zero arguments from JS (fixes arity mismatch error) - Default to returning a ByteArray when no encoding is provided - Normalize encoding values and ensure lowercase comparisons - Aligns NodeHash behavior with Node.js crypto.Hash This fixes guest tests that are calling `hash.digest()` without arguments. Signed-off-by: Elijah Kotyluk <[email protected]>
Signed-off-by: Elijah Kotyluk <[email protected]>
…is passed. - Expand test coverage on digest method - Validate string check with Value type argument is working as expected in both host and guest Signed-off-by: Elijah Kotyluk <[email protected]>
…ate with test. Signed-off-by: Elijah Kotyluk <[email protected]>
a947c0f to
ab5e578
Compare
Summary
Implements Node.js Hash.
createHashmethodNodeHashclassNodeHash.update()methodNodeHash.clone()methodNodeHash.digest()methodChangelog
1.0