support-empty-requests-and-responses #405
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicksanford
force-pushed
the
support-empty-requests-and-responses
branch
from
29b308f to
e53c334
Compare
nicksanford
force-pushed
the
support-empty-requests-and-responses
branch
from
e53c334 to
ae8f152
Compare
polvalente
reviewed
Feb 10, 2025
| @@ -70,6 +69,8 @@ defmodule GRPC.Server.Transcode do | |||
| Map.get(response_body, key) | |||
| end | |||
|
|
|||
| def map_response_body(%{}, response_body), do: response_body | |||
There was a problem hiding this comment.
This doesn't match on an empty map. It matches on any map. You need to use when map_size(arg) == 0
There was a problem hiding this comment.
Also, please add tests for this
|
@nicksanford @polvalente I was wondering why this was necessary. Can you explain it to me? |
I was hoping to discover when reading the test case I requested 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.