-
-
Notifications
You must be signed in to change notification settings - Fork 567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: partially support fedibird emoji reactions (read-only) #3033
Open
shuuji3
wants to merge
7
commits into
main
Choose a base branch
from
shuuji3/feat/emoji-reactions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for elk-docs canceled.
|
shuuji3
force-pushed
the
shuuji3/feat/emoji-reactions
branch
from
October 31, 2024 16:20
990849f
to
988e033
Compare
shuuji3
force-pushed
the
shuuji3/feat/emoji-reactions
branch
from
December 19, 2024 13:52
77d249e
to
08b908b
Compare
shuuji3
changed the title
feat: partially support read-only emoji reactions
feat: partially support fedibird emoji reactions (read-only)
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #3029
Sample post with emoji reactions:
https://deploy-preview-3033--elk-zone.netlify.app/universeodon.com/@[email protected]/113389571144372566
To show Fedibird emoji reaction, the test user needs to log in with
@fedibird.com
account so the current test account@[email protected]
cannot see the emoji reaction on the Netlify preview. Currently, fedibird.com limited registration but I can issue the invitation code if needed to test this PR.Screenshots
Two emoji reactions sent from me
Hover style on emoji reaction button (currently no action)
The mouse cursor is on the right button before sending emoji reactions.
Mock with many emoji reactions
Reference on fedibird.com