Skip to content

feat: partially support fedibird emoji reactions (read-only) #3033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

shuuji3
Copy link
Member

@shuuji3 shuuji3 commented Oct 31, 2024

resolve #3029

Sample post with emoji reactions:
https://deploy-preview-3033--elk-zone.netlify.app/universeodon.com/@[email protected]/113389571144372566

To show Fedibird emoji reaction, the test user needs to log in with @fedibird.com account so the current test account @[email protected] cannot see the emoji reaction on the Netlify preview. Currently, fedibird.com limited registration but I can issue the invitation code if needed to test this PR.

Screenshots

Two emoji reactions sent from me

Screenshot of emoji reaction, both buttons sent from me

Hover style on emoji reaction button (currently no action)

The mouse cursor is on the right button before sending emoji reactions.
Screenshot of emoji reaction, left button is gray without border, right is plus with gray border

Mock with many emoji reactions

Screenshot of many emoji reaction in two lines

Reference on fedibird.com

Screenshot of status on fedibird.com

Copy link

netlify bot commented Oct 31, 2024

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit 04b5645
🔍 Latest deploy log https://app.netlify.com/projects/elk-zone/deploys/682d5c77c39bec00088fd816
😎 Deploy Preview https://deploy-preview-3033--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented Oct 31, 2024

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit 04b5645
🔍 Latest deploy log https://app.netlify.com/projects/elk-docs/deploys/682d5c772584f90008530130

@shuuji3 shuuji3 force-pushed the shuuji3/feat/emoji-reactions branch from 990849f to 988e033 Compare October 31, 2024 16:20
@shuuji3 shuuji3 force-pushed the shuuji3/feat/emoji-reactions branch from 77d249e to 08b908b Compare December 19, 2024 13:52
@shuuji3 shuuji3 changed the title feat: partially support read-only emoji reactions feat: partially support fedibird emoji reactions (read-only) Dec 19, 2024
@shuuji3 shuuji3 marked this pull request as ready for review December 19, 2024 14:48
@ayoayco ayoayco closed this Feb 9, 2025
@ayoayco ayoayco deleted the shuuji3/feat/emoji-reactions branch February 9, 2025 14:24
@shuuji3 shuuji3 restored the shuuji3/feat/emoji-reactions branch February 9, 2025 14:45
@shuuji3 shuuji3 reopened this Feb 9, 2025
@neet
Copy link
Member

neet commented May 8, 2025

We improved support for declaration merging in [email protected] so it can be simplified as follows!

// global.d.ts
import "masto";

declare module "masto/mastodon/entities/v1/index.js" {
  interface EmojiReaction {
    name: string
    count: number
    accountIds: string[]
    me: boolean
    url?: string
    staticUrl?: string
    domain?: string | null
    width?: number
    height?: number
  }

  interface Status {
    emojiReactionsCount?: number;
    emojiReactions?: EmojiReaction[] 
  }
}

@shuuji3 shuuji3 force-pushed the shuuji3/feat/emoji-reactions branch from b4f5724 to 04b5645 Compare May 21, 2025 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support fedibird emoji reaction
3 participants