Add roundtrip fuzzing for LogReader
#152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliotgoodrich
force-pushed
the
logreader-extra-fuzzing
branch
from
52d271a to
abb71dc
Compare
Add fuzzing for `LogReader` by roundtripping a corpus twice through `LogWriter` and checking that the first and second outputs are identical. We have to roundtrip twice and not compare against the original since there are numerous inputs that map to the same `LogEntry`, e.g. all integers can have any number of leading zeros. Perhaps in the future we can tighten up the format so there is a 1-1 mapping, but this should be fine for the moment. `LogReader` is by no means optimal in terms of performance. But there is little reason to start optimizing now before proper benchmarks exist.
elliotgoodrich
force-pushed
the
logreader-extra-fuzzing
branch
from
abb71dc to
2eed50a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add fuzzing for
LogReaderby roundtripping a corpus twice throughLogWriterand checking that the first and second outputs are identical.We have to roundtrip twice and not compare against the original since there are numerous inputs that map to the same
LogEntry, e.g. all integers can have any number of leading zeros. Perhaps in the future we can tighten up the format so there is a 1-1 mapping, but this should be fine for the moment.LogReaderis by no means optimal in terms of performance. But there is little reason to start optimizing now before proper benchmarks exist.