Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Elyra to KFP v2 (cont.) #3273

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Conversation

caponetto
Copy link
Contributor

What changes were proposed in this pull request?

Moving forward with the work started in #3219

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@caponetto caponetto requested a review from lresende January 3, 2025 14:17
@@ -730,7 +709,7 @@
pipeline.pipeline_properties.get(pipeline_constants.COS_OBJECT_PREFIX), pipeline_instance_id
)
# - load the generic component definition template
template_env = Environment(loader=PackageLoader("elyra", "templates/kubeflow/v1"))
template_env = Environment(loader=PackageLoader("elyra", "templates/kubeflow/v2"))

Check warning

Code scanning / CodeQL

Jinja2 templating with autoescape=False Medium

Using jinja2 templates with autoescape=False can potentially allow XSS attacks.
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
Copy link
Contributor

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

just few details:

  • we removed kfp-tekton in initial work as it only support kfp 1.x , not kfp 2.x.
    The project: https://github.com/kubeflow/kfp-tekton/releases, is updating time to time, so in case someone wants to include tekton support, would need to check and accommodate it. As kfp itself is aligning on argo, perhaps going forward with that way be the best, based on my observation.
  • Some changes are explicit of the ODH.

elyra/pipeline/kfp/kfp_processor.py Outdated Show resolved Hide resolved
elyra/pipeline/kfp/kfp_processor.py Outdated Show resolved Hide resolved
@caponetto
Copy link
Contributor Author

Thanks for the review, @harshad16! I'll look into the points you've raised.

@lresende
Copy link
Member

Could we remove the tekton options and docs as well ?

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 77.98165% with 24 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@f38c645). Learn more about missing BASE report.

Files with missing lines Patch % Lines
elyra/tests/pipeline/kfp/test_kfp_processor.py 81.70% 15 Missing ⚠️
elyra/pipeline/kfp/kfp_processor.py 52.63% 9 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3273   +/-   ##
=======================================
  Coverage        ?   82.83%           
=======================================
  Files           ?      161           
  Lines           ?    19830           
  Branches        ?      509           
=======================================
  Hits            ?    16426           
  Misses          ?     3220           
  Partials        ?      184           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants