Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle paths with spaces (#944) #958

Closed
wants to merge 1 commit into from
Closed

fix: handle paths with spaces (#944) #958

wants to merge 1 commit into from

Conversation

macabeus
Copy link
Contributor

@macabeus macabeus commented Dec 21, 2024 •
edited
Loading

bogeychan
bogeychan approved these changes Dec 21, 2024
View reviewed changes
Copy link
Contributor

@bogeychan bogeychan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@macabeus macabeus mentioned this pull request Dec 22, 2024
Open
@SaltyAom
Copy link
Member

I would second this.

Instead of adding decodeURI on the runtime, I think I would add a check on the route registration phase to see if the route is equal to encodeURI(route).

Then if not equal, create an encoded route that points to a non-encoded route.

This would move the compute of decodeURI from every request to once on precompile time.

@SaltyAom SaltyAom self-assigned this Feb 16, 2025
@SaltyAom
Copy link
Member

Anyway let me do just that, give me 5 minute

michele-michelle

@SaltyAom
Copy link
Member

Closing in favor of e67b2a3

@SaltyAom SaltyAom closed this Feb 16, 2025
@macabeus macabeus deleted the fix-issue-944 branch February 17, 2025 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogeychan bogeychan bogeychan approved these changes

Assignees

@SaltyAom SaltyAom

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@macabeus @SaltyAom @bogeychan