Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

evil-ex: elisp: eldoc #1410

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

evil-ex: elisp: eldoc #1410

wants to merge 3 commits into from

Commits on Jan 25, 2021

  1. `evil-ex': eldoc for Elisp expressions 

    Refactor the `evil-ex' Elisp check into a new function, `evil-ex--elisp-p',
since it is used twice now. Add an `eldoc' function that calls
`elisp-eldoc-documentation-function' if in an Elisp expression and if the former
is available.
    @nbfalcon
    nbfalcon committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    cb75dd8 View commit details
    Browse the repository at this point in the history

  2. Refactor: use make-local-variable' to set capf' 

    `make-variable-buffer-local' should not be used in Elisp and makes the argument
permanently buffer-local. Use `make-local-variable' + `set' instead, maing
`evil-ex-setup' not set `completion-at-point-functions' as permanently
buffer-local and allowing to remove `with-no-warnings'.
    @nbfalcon
    nbfalcon committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    8b9ccc7 View commit details
    Browse the repository at this point in the history

  3. evil-ex': eldoc': support Emacs < 24.4 

    For Emacs < 24.4, which does not have `add-function' and `remove-function', use
`add-to-list' + `eldoc-documentation-functions' instead.
    @nbfalcon
    nbfalcon committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    fa9c54b View commit details
    Browse the repository at this point in the history