Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: CI: enable check for lack of new warnings while byte-compiling #1860

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

WIP: CI: enable check for lack of new warnings while byte-compiling #1860

wants to merge 4 commits into from

Commits on Feb 20, 2024

  1. evil-types.el: fix deprecation warning for Evil's internal variable 

    There's no point in this warning, because it is defined and processed
inside evil-mode. The warning only matters for user-side usage. So
disable it here.

Fixes:
    evil-types.el:96:22: Error: ‘evil-want-visual-char-semi-exclusive’ is an obsolete variable (as of 1.15.0); Semi-exclusivity prevents selecting text + 1st char of next line,
    without having to introduce new niche functionality.
    @Hi-Angel
    Hi-Angel committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    558f50e View commit details
    Browse the repository at this point in the history

  2. evil-commands.el: require seq, tab-bar and subr-x libs 

    Fixes warnings like:

    evil-commands.el:5205:1:Error: the following functions are not known to be defined: string-trim-right, tab-bar-close-tab, tab-close, tab-bar-select-tab, tab-bar-switch-to-next-tab
    @Hi-Angel
    Hi-Angel committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    fbc5f99 View commit details
    Browse the repository at this point in the history

  3. Makefile: suppress warning for undo-redo being undefined 

    It is part of the newer Emacs, but on the older ones it causes
warnings. There's no tests of that functionality, so just suppress the
warning.
    @Hi-Angel
    Hi-Angel committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    d79c5fe View commit details
    Browse the repository at this point in the history

  4. ci: check for lack of byte-compilation warnings 

    As part of that we test with latest released Emacs version rather than
snapshot, because we don't want CI to start suddenly failing on
unrelated changes because upstream introduced a new warning/check.
    @Hi-Angel
    Hi-Angel committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    8965783 View commit details
    Browse the repository at this point in the history