Promises reworked, menubar functionality in events/options improved #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shoshins
commented
Jan 20, 2017
shoshins
commented
- Promises significantly improved;
- ready/afterready events converted to promises;
- options parameters for menu page invocation;
- babel polyfill already exists check added
- custom menu template option
Parser.dom Navigation.presentModal Navigation.show Navigation.showLoading Navigation.showError Navigation.initMenu Page.makeDom Page.makePage (ready remaked) Menu.get Menu.create
menu loader/error default templates
promises corrected for: Navigation.getLoaderDoc Navigation.getErrorDoc Handler.onMenuItemSelect
page create function promise improved (redundant one removed)
…enubar template option
shoshins
changed the title
package.json
Outdated
| { | ||
| "name": "atvjs", | ||
| "version": "0.2.5", | ||
| "version": "0.2.6", |
There was a problem hiding this comment.
I suggest update major version because of breaking changes in this PR.
Here are major semver rules:
1.X.X— Major update for breaking changes. Even if they are mostly backward compatibleX.1.X— Minor update for new features with backward compatibility.X.X.1— Patch update only for bugfixes.
Author
There was a problem hiding this comment.
Yeah, it's true. I could not afford to change major version of library that was created by another person)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.