Remove Git LFS from repo #10
Conversation
|
|
||
|
|
||
| # download the videos | ||
| from huggingface_hub import hf_hub_url |
There was a problem hiding this comment.
At runtime we download the videos from Huggingface. No need to keep them in this repo as I assume they are static and people won't be iterating on them.
|
|
||
| with open(elo_rating_pkl, "rb") as fin: | ||
| elo_rating_results = pickle.load(fin) | ||
| elo_rating_results = load_results(elo_rating_folder) |
There was a problem hiding this comment.
Results are now saved and loaded as folders, but it does make the commits quite long as each dataframe is a separate file... sorry!
| mteb | ||
| plotly | ||
| umap-learn | ||
| kaleido |
There was a problem hiding this comment.
Apparently is needed to write Plotly plots to file. We could not save to file, but it was saved in the pickle files, so I thought we might as well write it to file for now.
isaac-chung
left a comment
isaac-chung
left a comment
There was a problem hiding this comment.
Generally it looks good! Just wondering if we can simplify the structure a bit.
|-- elo_results_TASK
|-- anony
- |-- average_win_rate_bar
- |-- default.png
+ |-- average_win_rate_bar.png
|-- full| mkdir -p results | ||
|
|
||
| mkdir -p results/latest |
There was a problem hiding this comment.
Probably don't need mkdir -p results since we have the new line?
To avoid bandwidth issues with Github's 1GB of Git-LFS bandwidth, remove files that use Git LFS:
@Muennighoff @isaac-chung Can I remove the
index_*/passages.*.ptfiles from Github LFS? I assume not yet and when the other indexes are ready we can remove them, so just lmk. Those are the last git lfs files.