Adds VocalSound dataset #2337
Open
Adds VocalSound dataset #2337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mina-parham
added
new dataset
Samoed
reviewed
Mar 12, 2025
Comment on lines
51
to
52
| def dataset_transform(self): | ||
| self.dataset["train"] = self.dataset["test"] |
There was a problem hiding this comment.
I think it would be better to use cross-validation instead of test
There was a problem hiding this comment.
Test split should be removed, because for now training and testing would be on same test split
isaac-chung
reviewed
Mar 12, 2025
Co-authored-by: Isaac Chung <[email protected]>
Co-authored-by: Isaac Chung <[email protected]>
…-benchmark/mteb into AddDataset/VocalSound
Samoed
reviewed
Mar 26, 2025
Open
isaac-chung
reviewed
Apr 14, 2025
| table_dict[lang] = {k: 0 for k in sorted(get_args(TASK_TYPE))} | ||
| table_dict[lang] = dict.fromkeys(sorted(get_args(TASK_TYPE)), 0) |
There was a problem hiding this comment.
I'd prefer if these changes were reverted. Feel free to open a separate issue, and a PR to main
There was a problem hiding this comment.
It seems that this file was formatted with different ruff version
| month=may } | ||
| }""", | ||
| descriptive_stats={ | ||
| "n_samples": {"validation": 1860, "test": 3594}, |
There was a problem hiding this comment.
To match eval_splits
Suggested change
| "n_samples": {"validation": 1860, "test": 3594}, | |
| "n_samples": {"test": 3594}, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2313
Code Quality
make lintto maintain consistent style.Documentation
Testing
make test-with-coverage.make testormake test-with-coverageto ensure no existing functionality is broken.Adding datasets checklist
Reason for dataset addition: ...
mteb -m {model_name} -t {task_name}command.sentence-transformers/paraphrase-multilingual-MiniLM-L12-v2intfloat/multilingual-e5-smallself.stratified_subsampling() under dataset_transform()make test.make lint.