Only remove type imports #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ember-cli uses `babel-remove-types` to remove types from .gts files and if some of the imported references are only used in the `<template>` context, babel assumes they are unused and removes them. By enabling the `onlyRemoveTypeImports` option of `@babel/plugin-transform-typescript` those imports are now no longer stripped. Co-Authored-By: Bert De Block <[email protected]>
Windvis
force-pushed
the
only-remove-type-imports
branch
from
6302333 to
fdf4822
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ember-cli uses
babel-remove-typesfor removing types from .gts files and if some of the imported references are only used in the<template>context, babel assumes they are unused and removes them.By enabling the
onlyRemoveTypeImportsoption of@babel/plugin-transform-typescriptthose imports are now no longer stripped.Context on why this is needed:
.gtsfiles in blueprints ember-cli#10619