Update generated ESLint config #110
Merged
+8
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bertdeblock
commented
Nov 7, 2025
| }, | ||
| ]; | ||
| <% if (typescript) { %> | ||
| export default ts.config(...config);<% } else { %> |
Member
Author
There was a problem hiding this comment.
ts.config is deprecated in favor of defineConfig. I've verified locally, that the exact same configs are printed before and after.
bertdeblock
commented
Nov 7, 2025
| <% } %> | ||
| const config = [ | ||
| export default defineConfig([ | ||
| globalIgnores(['dist/', 'dist-*/', 'declarations/', 'coverage/', '!**/.*']), |
Member
Author
There was a problem hiding this comment.
node_modules are ignored by default, so not included here anymore.
bertdeblock
force-pushed
the
eslint-config-updates
branch
from
a175991 to
73a7bee
Compare
bertdeblock
commented
Nov 7, 2025
| languageOptions: { | ||
| parser: ember.parser, | ||
| parserOptions: tsParserOptions, | ||
| globals: { |
Member
Author
There was a problem hiding this comment.
Was missing here it seems, not sure why this wasn't an issue before.
This was the cause of the failing jobs in https://github.com/ember-cli/ember-addon-blueprint/actions/runs/19166271947
bertdeblock
commented
Nov 7, 2025
| { | ||
| files: [ | ||
| '**/*.cjs', | ||
| '.prettierrc.cjs', |
Member
Author
There was a problem hiding this comment.
Removed these 3 because of **/*.cjs.
NullVoxPopuli
approved these changes
Nov 7, 2025
This was referenced Nov 7, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.