Don't emit application.hbs, use application.gjs #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mansona
requested changes
May 19, 2025
Member
mansona
left a comment
mansona
left a comment
There was a problem hiding this comment.
So I don't think we can do this until Ember 6.5 🤔 If we want to use this blueprint as a preview with GJS all the way then we need to enable the strict blueprints by default, and we could consider using the beta now to allow for this. But we can't have the default application template be GJS and when you call ember g route fancy-route it generate a hbs
Contributor
Author
|
I don't think the generators being behind is a blocker. The blueprint is meant to be how we want apps to be. |
Member
|
I'll add this to the agenda for today. For the record I'm totally happy to target beta for the app blueprint for this reason 👍 |
Contributor
Author
|
now with beta! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.