fix: align linters with recent changes in classic app blueprint #119
+12
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I think the test failures are pointing out that our engine declaration is wrong 🤔 https://github.com/ember-cli/ember-app-blueprint/blob/main/files/package.json#L106 I'm pretty sure that now we are on Vite 7 we should update this as a bugfix against release |
mansona
force-pushed
the
fix/align-linters-with-classic
branch
from
60dbc5f to
8d30daf
Compare
NullVoxPopuli
force-pushed
the
fix/align-linters-with-classic
branch
from
8d30daf to
c8c533f
Compare
Contributor
|
I rebased for ye |
Contributor
|
current issue on non-windows: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some important changes in classic app blueprint which this new blueprint is missing