Restore correct version of babel-plugin-ember-template-compilation #134
+3
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
babel-plugin-ember-template-compilation was downgraded from 3.x to 2.x only to keep eslint happy. That's not good, we should be shipping the current major. Also, everybody still has 3.x also, because `@embroider/core` depend on it. The mixing is inconsistent.
Contributor
Author
|
This will also need: ember-tooling/ember-eslint-parser#137 |
Contributor
I don't think this was enough 🤔 it helped! though as I see far fewer errors in a local project |
Contributor
|
@NullVoxPopuli @ef4 should just need to remove |
NullVoxPopuli
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
babel-plugin-ember-template-compilation was downgraded from 3.x to 2.x only to keep eslint happy. That's not good, we should be shipping the current major.
Also, everybody still has 3.x also, because
@embroider/coredepend on it. The mixing is inconsistent.