Skip to content

Conversation

@rykov
Copy link
Contributor

@rykov rykov commented Aug 2, 2025

I've had trouble chaining multiple custom separators, and I tracked it down to this code in sortedTokens that always copies the separator from the previous token in the group overriding any customization. Given that the separator default & inheritance logic is done in push(..), specifically by inheritFromPrevious and applyTokenDefaults, I've found that the lastToken logic in sortedTokens was a bug.

@knownasilya
Copy link
Contributor

knownasilya commented Aug 21, 2025

Could someone approve the workflow to run? @NullVoxPopuli?

@NullVoxPopuli
Copy link
Contributor

you betchya!

@rykov
Copy link
Contributor Author

rykov commented Aug 22, 2025

@NullVoxPopuli I've reverted the benign change that was causing the workflow to fail on Lint. Can we try running it again?

Strangely, the workflow failed with this prettier/prettier lint error:

47:25  error  Replace `declare·privat` with `private·declar`  prettier/prettier

However, my local install was/is giving me the opposite advice that prompted that change in the first place:

47:25  error  Replace `private·declar` with `declare·privat`  prettier/prettier    

@NullVoxPopuli NullVoxPopuli merged commit 76ec72b into ember-cli:master Aug 22, 2025
18 checks passed
@github-actions github-actions bot mentioned this pull request Aug 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants