Add compatToRFC1132 utility #15
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please someone suggest a better name for this 🙈
In chatting with @RobbieTheWagner, it's become clear we do need to provide some utilities for interfacing with the old stuff, since we haven't shipped (and made everyone migrate to) the static/importable replacements for all the registry stuff just yet.
This utility works with
@embroider/virtual/compat-modulesand converts it to the strict format.There is still work to make
@embroider/virtual/compat-modules"somehow" detect when its being used with the strict module format in RFC 1132, but I don't know how to set that up atm, and I think this utility would be good regardless, as I think this library exposing a few conversion utilities would be good.After this PR, there are also planned:
(all 3 for separate PRs)