preserve escape characters #222
Conversation
| test('string-mixed-line-endings', () => { | ||
| let input = '{{foo-bar placeholder="Choose a... \\t\\r\\n"}}'; | ||
|
|
||
| expect(runTest('string-mixed-line-endings.hbs', input)).toMatch( |
There was a problem hiding this comment.
@Turbo87 I had to change to toMatch from toMatchInlineSnapshot because toMatchInlineSnapshot runs prettier not allowing me to express the string correctly for the test. I
|
|
||
| if (_value.chars && _value.chars.length > 0) { | ||
| _value.chars = JSON.stringify(_value.chars).slice(1, -1); | ||
| } |
There was a problem hiding this comment.
I don't understand this. What are we stringifying something here?
There was a problem hiding this comment.
The reason i do this is because _value has the \ stripped within the string:
hence:"Choose a "thing"..."
JSON.stringify is great at escaping strings. So I use it to properly escape strings and remove the first and last double-quote resulting in Choose a \"thing\"...
There was a problem hiding this comment.
isn't that a bug in the printer or template-recast?
There was a problem hiding this comment.
I didn’t consider that. I guess I could check how other parsers handle such things. I’ll look into this a little more.
fixes #219