Feat: Include Glimmer component arguments as being tracked#182
Open
IgnaceMaes wants to merge 2 commits intoember-codemods:masterfrom
Open
Feat: Include Glimmer component arguments as being tracked#182IgnaceMaes wants to merge 2 commits intoember-codemods:masterfrom
IgnaceMaes wants to merge 2 commits intoember-codemods:masterfrom
Conversation
Author
|
FYI @suchitadoshi1987 @tylerturdenpants As this might get lost in between Dependabot PRs as this repo hasn't been updated in a bit 😄 |
Collaborator
|
@IgnaceMaes I will try and take a close look today. So far the PR looks ok, but I want to be sure. |
Author
|
This should probably be updated to use @dependentKeyCompat for full compatibility in case there are CPs watching these getters. Although I suspect this might be required for the other functionality of the codemod as well? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Glimmer component arguments are auto tracked by default. So when in a Glimmer component, we can safely ignore these if they're part of the computed property watchlist.
This is only true for the reference of the argument itself, and not nested properties. For this a check has been added as well.