Lexical this #67
Merged
Lexical this #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI was disabled -- I re-enabled it, but it won't run unless you push again |
|
(Actually I think content-tag will not need a change, the |
Kind of, but there are some nuances to discuss. Let's discuss it on today's spec call and summarize on this thread afterward. |
|
The glimmer-vm changes are landed and integrated into ember. This PR just needs to make some decisions about test coverage. The repo currently only tests the oldest supported ember-source, but this feature only works in newer ember-source, so we should presumably invest in a bit of matrix testing. |
Needs ember-source >= 6.4.0 to actually work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to fix #61.
It has a test failure because related changes are also needed in glimmer and content-tag.