Skip to content

default globals implementation #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 20, 2025
Merged

default globals implementation #68

merged 8 commits into from
Mar 20, 2025

Conversation

NullVoxPopuli
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli commented Jan 14, 2025 •
edited
Loading

NullVoxPopuli
NullVoxPopuli commented Jan 14, 2025
View reviewed changes
@ef4
Copy link
Contributor

ef4 commented Jan 15, 2025

This looks like a good start covering the ECMA globals. Perhaps we also care about some WHATWG globals:

https://html.spec.whatwg.org/multipage/nav-history-apis.html#window

I think it's fine to be choosy, there is definitely stuff in there that is pretty much legacy (like name) that is probably just a troll. But other things seems likely to be useful and people will try to use them (focus? blur? postMessage?).

@NullVoxPopuli
Copy link
Contributor Author

oooo, ya good thinking. doing (fn postMessage ...) would make for some fun demos

@NullVoxPopuli NullVoxPopuli changed the title WIP/do-not-merge (yet): prototype out default globals implementation default globals implementation Jan 18, 2025
@NullVoxPopuli NullVoxPopuli mentioned this pull request Jan 18, 2025
Merged
11 tasks
Techn1x
Techn1x reviewed Feb 24, 2025
View reviewed changes
@NullVoxPopuli NullVoxPopuli marked this pull request as ready for review March 1, 2025 21:05
@NullVoxPopuli
Copy link
Contributor Author

done!

@NullVoxPopuli
Copy link
Contributor Author

CI fixes extracted to #71

@NullVoxPopuli NullVoxPopuli force-pushed the default-utilites-from-window branch from 2388d34 to 7e23656 Compare March 18, 2025 19:43
@ef4 ef4 merged commit c60fdce into main Mar 20, 2025
5 checks passed
@github-actions github-actions bot mentioned this pull request Mar 20, 2025
Merged
@mansona
Copy link
Member

mansona commented Mar 20, 2025

@NullVoxPopuli @ef4 any feeling on what the impact of this change is? it feels like it's kinda breaking but not really in a way that should be exposed to the end user 🤔

@ef4 ef4 added the enhancement New feature or request label Mar 20, 2025
@NullVoxPopuli
Copy link
Contributor Author

it's 100% non-breaking, because if you tried to use a global before this PR, you'd just have an error.

@ef4
Copy link
Contributor

ef4 commented Mar 20, 2025

Correct, it's not breaking.

@ef4 ef4 mentioned this pull request Mar 28, 2025
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ef4 ef4 ef4 left review comments

@Techn1x Techn1x Techn1x left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NullVoxPopuli @ef4 @mansona @Techn1x