Convert to esm #77
Merged
Convert to esm #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Merged
moisesbramirez
added a commit
to retailnext/ember-bem-helpers
that referenced
this pull request
May 7, 2025
Per [author's pull request note]: > For ember-cli users, if you have ember-cli-babel 8.x and allow your > deps to update to compatible patch releases, async plugins like this > will work for you. Hoping this [fixes the Parsing error coming from Babel]. [author's pull request note]: emberjs/babel-plugin-ember-template-compilation#77 [fixes the Parsing error coming from Babel]: https://github.com/retailnext/ember-bem-helpers/actions/runs/14869650382/job/41754910951?pr=597#step:6:29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change because you must use this plugin in contexts where babel is allowed to be asynchronous.
For ember-cli users, if you have ember-cli-babel 8.x and allow your deps to update to compatible patch releases, async plugins like this will work for you.
The major benefit is that this plugin can now load the ember template compiler and AST transforms via ESM.