Fix incorrect "this" binding when there's a TypeScript this arg in scope
#80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…scope Our `mayUseLexicalThis` guard was not fully guarding against treating a template's `this` as the lexically scoped one. This went unnoticed because to trigger the bug you also need babel to tell you that the identifier `this` is in scope, which normally won't happen, except in TypeScript with a `this` function argument.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our
mayUseLexicalThisguard was not fully guarding against treating a template'sthisas the lexically scoped one. This went unnoticed because to trigger the bug you also need babel to tell you that the identifierthisis in scope, which normally won't happen, except in TypeScript with athisfunction argument.Fixes #79