Skip to content

[Next] Kill array and proxy mixins #20921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2025
Merged

[Next] Kill array and proxy mixins #20921

merged 1 commit into from
Jun 11, 2025

Conversation

wagenet
Copy link
Member

@wagenet wagenet commented Jun 10, 2025 •
edited
Loading

This kills the array mixin. It has some affect on routing which we have hacked around.

This should not be merged into main until @ember/array, @ember/array/mutable, and the array computed macros have been deprecated.

Additionally, we should carefully test the routing changes.

@wagenet wagenet force-pushed the kill-array-mixins branch 2 times, most recently from 7a9a08a to d0d21f8 Compare June 10, 2025 20:48
@wagenet wagenet changed the base branch from main to next June 10, 2025 21:08
@wagenet wagenet changed the title WIP: Kill array and proxy mixins [Next] Kill array and proxy mixins Jun 10, 2025
@wagenet wagenet force-pushed the kill-array-mixins branch from d0d21f8 to 4fc94e7 Compare June 11, 2025 01:06
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 11, 2025 •
edited
Loading

Development Assets

Diff

--- main/out.txt	2025-06-11 01:12:44.000000000 +0000
+++ pr/./pr-15596190164/out.txt	2025-06-11 21:34:28.000000000 +0000
@@ -1,35 +1,34 @@
 2.2M └─┬ .
-996K   ├─┬ @ember
-187K   │ ├─┬ -internals
- 50K   │ │ ├─┬ views
- 46K   │ │ │ └─┬ lib
+930K   ├─┬ @ember
+181K   │ ├─┬ routing
+ 27K   │ │ └── lib
+165K   │ ├─┬ -internals
+ 44K   │ │ ├─┬ views
+ 39K   │ │ │ └─┬ lib
  21K   │ │ │   ├── system
- 10K   │ │ │   ├── views
-5.6K   │ │ │   ├── mixins
+9.1K   │ │ │   ├── views
 4.3K   │ │ │   └── compat
- 35K   │ │ ├─┬ runtime
- 30K   │ │ │ └─┬ lib
- 21K   │ │ │   ├── mixins
-5.7K   │ │ │   └── ext
  26K   │ │ ├─┬ meta
  21K   │ │ │ └── lib
+ 20K   │ │ ├─┬ runtime
+ 16K   │ │ │ └─┬ lib
+6.4K   │ │ │   ├── mixins
+5.7K   │ │ │   └── ext
  11K   │ │ ├── owner
 9.4K   │ │ ├── deprecations
-7.4K   │ │ ├── metal
+7.3K   │ │ ├── metal
 7.0K   │ │ ├── string
 5.0K   │ │ ├── glimmer
-4.9K   │ │ ├── utils
 4.9K   │ │ ├── routing
+4.8K   │ │ ├── utils
 4.5K   │ │ ├── error-handling
 4.5K   │ │ ├── utility-types
 4.2K   │ │ ├── container
 4.2K   │ │ ├── browser-environment
 4.1K   │ │ └── environment
-183K   │ ├─┬ routing
- 28K   │ │ └── lib
-149K   │ ├─┬ object
- 66K   │ │ └─┬ lib
- 62K   │ │   └── computed
+137K   │ ├─┬ object
+ 63K   │ │ └─┬ lib
+ 59K   │ │   └── computed
 114K   │ ├─┬ template-compiler
 109K   │ │ └─┬ lib
  20K   │ │   ├── plugins
@@ -37,19 +36,19 @@
 4.1K   │ │   └── -internal
  65K   │ ├─┬ application
 5.6K   │ │ └── lib
- 52K   │ ├─┬ debug
+ 51K   │ ├─┬ debug
  21K   │ │ └── lib
- 38K   │ ├─┬ array
-4.9K   │ │ └── lib
- 31K   │ ├─┬ engine
+ 30K   │ ├─┬ engine
 4.7K   │ │ └── lib
- 27K   │ ├── runloop
+ 26K   │ ├── runloop
  22K   │ ├─┬ utils
- 18K   │ │ └── lib
+ 17K   │ │ └── lib
  20K   │ ├── helper
+ 11K   │ ├─┬ array
+4.8K   │ │ └── lib
  11K   │ ├── destroyable
 9.8K   │ ├── instrumentation
-9.4K   │ ├── controller
+9.0K   │ ├── controller
 7.4K   │ ├── service
 7.2K   │ ├── owner
 6.2K   │ ├── component
@@ -63,7 +62,7 @@
 4.2K   │ ├── deprecated-features
 4.1K   │ ├── template-factory
 4.1K   │ └── version
-722K   ├── shared-chunks
+718K   ├── shared-chunks
 384K   ├─┬ @glimmer
 166K   │ ├── runtime
  60K   │ ├── opcode-compiler
@@ -82,15 +81,16 @@
 4.9K   │ ├── encoder
 4.6K   │ ├── owner
 4.1K   │ └── env
- 60K   ├─┬ ember-testing
- 55K   │ └─┬ lib
+ 58K   ├─┬ ember-testing
+ 54K   │ └─┬ lib
  14K   │   ├── test
- 14K   │   ├── helpers
+ 13K   │   ├── helpers
  10K   │   ├── ext
 6.4K   │   └── adapters
  31K   ├── backburner.js
- 25K   ├── ember
  24K   ├── route-recognizer
+ 23K   ├── ember
+ 21K   ├── tracked-built-ins
  18K   ├─┬ @simple-dom
  14K   │ └── document
 9.2K   ├── dag-map

Details

This PRmain
Dev 
2.2M └─┬ .
930K   ├─┬ @ember
181K   │ ├─┬ routing
 27K   │ │ └── lib
165K   │ ├─┬ -internals
 44K   │ │ ├─┬ views
 39K   │ │ │ └─┬ lib
 21K   │ │ │   ├── system
9.1K   │ │ │   ├── views
4.3K   │ │ │   └── compat
 26K   │ │ ├─┬ meta
 21K   │ │ │ └── lib
 20K   │ │ ├─┬ runtime
 16K   │ │ │ └─┬ lib
6.4K   │ │ │   ├── mixins
5.7K   │ │ │   └── ext
 11K   │ │ ├── owner
9.4K   │ │ ├── deprecations
7.3K   │ │ ├── metal
7.0K   │ │ ├── string
5.0K   │ │ ├── glimmer
4.9K   │ │ ├── routing
4.8K   │ │ ├── utils
4.5K   │ │ ├── error-handling
4.5K   │ │ ├── utility-types
4.2K   │ │ ├── container
4.2K   │ │ ├── browser-environment
4.1K   │ │ └── environment
137K   │ ├─┬ object
 63K   │ │ └─┬ lib
 59K   │ │   └── computed
114K   │ ├─┬ template-compiler
109K   │ │ └─┬ lib
 20K   │ │   ├── plugins
4.6K   │ │   ├── system
4.1K   │ │   └── -internal
 65K   │ ├─┬ application
5.6K   │ │ └── lib
 51K   │ ├─┬ debug
 21K   │ │ └── lib
 30K   │ ├─┬ engine
4.7K   │ │ └── lib
 26K   │ ├── runloop
 22K   │ ├─┬ utils
 17K   │ │ └── lib
 20K   │ ├── helper
 11K   │ ├─┬ array
4.8K   │ │ └── lib
 11K   │ ├── destroyable
9.8K   │ ├── instrumentation
9.0K   │ ├── controller
7.4K   │ ├── service
7.2K   │ ├── owner
6.2K   │ ├── component
5.6K   │ ├── canary-features
5.5K   │ ├── modifier
5.1K   │ ├── template-compilation
5.0K   │ ├── enumerable
5.0K   │ ├── test
4.4K   │ ├── template
4.4K   │ ├── renderer
4.2K   │ ├── deprecated-features
4.1K   │ ├── template-factory
4.1K   │ └── version
718K   ├── shared-chunks
384K   ├─┬ @glimmer
166K   │ ├── runtime
 60K   │ ├── opcode-compiler
 30K   │ ├── manager
 22K   │ ├── validator
 14K   │ ├── program
 12K   │ ├── reference
 11K   │ ├── destroyable
 10K   │ ├─┬ tracking
4.4K   │ │ └── primitives
 10K   │ ├── util
8.1K   │ ├── node
7.3K   │ ├── global-context
6.4K   │ ├── wire-format
5.0K   │ ├── vm
4.9K   │ ├── encoder
4.6K   │ ├── owner
4.1K   │ └── env
 58K   ├─┬ ember-testing
 54K   │ └─┬ lib
 14K   │   ├── test
 13K   │   ├── helpers
 10K   │   ├── ext
6.4K   │   └── adapters
 31K   ├── backburner.js
 24K   ├── route-recognizer
 23K   ├── ember
 21K   ├── tracked-built-ins
 18K   ├─┬ @simple-dom
 14K   │ └── document
9.2K   ├── dag-map
4.3K   ├── rsvp
4.3K   └── router_js

2.2M └─┬ .
996K   ├─┬ @ember
187K   │ ├─┬ -internals
 50K   │ │ ├─┬ views
 46K   │ │ │ └─┬ lib
 21K   │ │ │   ├── system
 10K   │ │ │   ├── views
5.6K   │ │ │   ├── mixins
4.3K   │ │ │   └── compat
 35K   │ │ ├─┬ runtime
 30K   │ │ │ └─┬ lib
 21K   │ │ │   ├── mixins
5.7K   │ │ │   └── ext
 26K   │ │ ├─┬ meta
 21K   │ │ │ └── lib
 11K   │ │ ├── owner
9.4K   │ │ ├── deprecations
7.4K   │ │ ├── metal
7.0K   │ │ ├── string
5.0K   │ │ ├── glimmer
4.9K   │ │ ├── utils
4.9K   │ │ ├── routing
4.5K   │ │ ├── error-handling
4.5K   │ │ ├── utility-types
4.2K   │ │ ├── container
4.2K   │ │ ├── browser-environment
4.1K   │ │ └── environment
183K   │ ├─┬ routing
 28K   │ │ └── lib
149K   │ ├─┬ object
 66K   │ │ └─┬ lib
 62K   │ │   └── computed
114K   │ ├─┬ template-compiler
109K   │ │ └─┬ lib
 20K   │ │   ├── plugins
4.6K   │ │   ├── system
4.1K   │ │   └── -internal
 65K   │ ├─┬ application
5.6K   │ │ └── lib
 52K   │ ├─┬ debug
 21K   │ │ └── lib
 38K   │ ├─┬ array
4.9K   │ │ └── lib
 31K   │ ├─┬ engine
4.7K   │ │ └── lib
 27K   │ ├── runloop
 22K   │ ├─┬ utils
 18K   │ │ └── lib
 20K   │ ├── helper
 11K   │ ├── destroyable
9.8K   │ ├── instrumentation
9.4K   │ ├── controller
7.4K   │ ├── service
7.2K   │ ├── owner
6.2K   │ ├── component
5.6K   │ ├── canary-features
5.5K   │ ├── modifier
5.1K   │ ├── template-compilation
5.0K   │ ├── enumerable
5.0K   │ ├── test
4.4K   │ ├── template
4.4K   │ ├── renderer
4.2K   │ ├── deprecated-features
4.1K   │ ├── template-factory
4.1K   │ └── version
722K   ├── shared-chunks
384K   ├─┬ @glimmer
166K   │ ├── runtime
 60K   │ ├── opcode-compiler
 30K   │ ├── manager
 22K   │ ├── validator
 14K   │ ├── program
 12K   │ ├── reference
 11K   │ ├── destroyable
 10K   │ ├─┬ tracking
4.4K   │ │ └── primitives
 10K   │ ├── util
8.1K   │ ├── node
7.3K   │ ├── global-context
6.4K   │ ├── wire-format
5.0K   │ ├── vm
4.9K   │ ├── encoder
4.6K   │ ├── owner
4.1K   │ └── env
 60K   ├─┬ ember-testing
 55K   │ └─┬ lib
 14K   │   ├── test
 14K   │   ├── helpers
 10K   │   ├── ext
6.4K   │   └── adapters
 31K   ├── backburner.js
 25K   ├── ember
 24K   ├── route-recognizer
 18K   ├─┬ @simple-dom
 14K   │ └── document
9.2K   ├── dag-map
4.3K   ├── rsvp
4.3K   └── router_js

@wagenet wagenet changed the title [Next] Kill array and proxy mixins [WIP] [Next] Kill array and proxy mixins Jun 11, 2025
@wagenet wagenet force-pushed the kill-array-mixins branch from 4fc94e7 to 3807477 Compare June 11, 2025 15:51
@wagenet wagenet changed the title [WIP] [Next] Kill array and proxy mixins [Next] Kill array and proxy mixins Jun 11, 2025
@wagenet wagenet marked this pull request as ready for review June 11, 2025 15:52
@wagenet wagenet force-pushed the kill-array-mixins branch from 3807477 to 1fa44dc Compare June 11, 2025 21:33
@wagenet wagenet merged commit e62120a into emberjs:next Jun 11, 2025
28 checks passed
@wagenet wagenet mentioned this pull request Jun 12, 2025
Draft
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wagenet