Config exports function rather than object #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More closely mirrors the config of `ember-cli-fastboot` itself and helps to avoid confusion.
gilest
force-pushed
the
feat/config-function
branch
from
19f0def
to
159d537
Compare
Closed
|
Can make it non-breaking by detecting if its a function and deprecating if it is not |
Good idea. Wasn't sure how to use
|
|
Thank you @gilest and @runspired! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More closely mirrors the config of
ember-cli-fastbootitself and helps to avoid confusion.One minor difference is that the
ember-cli-fastbootversion provides application environment as the first argument. Not sure this is necessary for a testing library as presumably it will always be'test'. Open to suggestions though.Breaking change but this addon is pre 1.0 so could target the next minor.
Should fix #488