Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Compat.toMap to retrieve a Map object from DataSource #79

Merged
merged 1 commit into from
May 25, 2024
Merged

Implement Compat.toMap to retrieve a Map object from DataSource #79

merged 1 commit into from
May 25, 2024

Conversation

dmikurube
Copy link
Member

Embulk's SPI has had DataSource#toMap, in addition to DataSource#toJson, since v0.10.41. embulk/embulk#1534

However, it has not been used from embulk-util-config so far yet. This pull request is the first step to start using toMap.

Constructing local ConfigSource from Map should be more efficient than from a stringified JSON.

@dmikurube dmikurube added this to the v0.5.1 milestone May 24, 2024
@dmikurube dmikurube requested a review from a team as a code owner May 24, 2024 08:27
hiroyuki-sato
hiroyuki-sato approved these changes May 25, 2024
View reviewed changes
Copy link
Member

@hiroyuki-sato hiroyuki-sato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@dmikurube
Copy link
Member Author

Thanks!

@dmikurube dmikurube merged commit 824c46e into main May 25, 2024
4 checks passed
@dmikurube dmikurube deleted the implement-Compat-toMap branch May 25, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiroyuki-sato hiroyuki-sato hiroyuki-sato approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v0.5.1
Development

Successfully merging this pull request may close these issues.
2 participants
@dmikurube @hiroyuki-sato