Support lone surrogate in pike #148
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isi-adas
approved these changes
Jan 6, 2025
Collaborator
|
cc: @isi-rszczesniak |
Collaborator
|
LGTM as a POC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend pike test to cover lone surrogate in filename.
Step 1: Create file with write/read, no delete on close
Step 2: Query file info
Step 3: Opening file with DELETE_ON_CLOSE
Step 4: Verifying file deletion
Current Implementation:
This version uses print statements to track the workflow's status at each step. Since Python's print function can raise errors when handling special surrogate characters, io.TextIOWrapper has been added to resolve this issue.
Logging Usage:
To enable log printing, use pytest -s. By default, the log-related code is commented out, and -s is not applied.