Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(content): use content from emdaer/emdaer as site sections #12

Merged
merged 3 commits into from
Nov 20, 2017

Conversation

infiniteluke
Copy link
Member

What:
Add a couple site sections shared from https://github.com/emdaer/emdaer

Why:
Updates to the emdaer readme should reflect in the website

How:
remark, remark-react

Checklist:

  • Documentation
  • Tests N/A
  • Ready to be merged
  • Added myself to AUTHORS

@emdaerbot
Copy link

Woohoo! new surge deployment available for viewing! 🎉 surgereviewinldsdevvubjoqa.surge.sh

@infiniteluke
Copy link
Member Author

☝️ I have no idea what we should do to make this look presentable.

@emdaerbot
Copy link

Woohoo! new surge deployment available for viewing! 🎉 surgereviewdbhwlbipjtpstpd.surge.sh

@infiniteluke
Copy link
Member Author

Design notes from @amazingrando

Notebook + other emojis to add color
Link to GitHub under “Create and Maintain..”
Bring in other colors as headers maybe
Try making first jumbotron colorful at top
Scale down h3 1.45 maybe dark gray
“Using emdaer in your project”
Add icons for each section - the noun project
Footer - simple/short

@flipactual
Copy link
Contributor

flipactual commented Nov 20, 2017

@infiniteluke per #12 (comment) – sorry, no

We're going to continue mimicking Facebook's open source projects' websites' designs as closely as we're able

Web design is not an area where emdaer cares to innovate

@infiniteluke
Copy link
Member Author

@flipactual Noted. Looking at https://reactjs.org/, it includes a couple of the suggestions @amazingrando made. So, I'll consider those on mark. Beyond that, I'll take the rest of my cues for https://reactjs.org/.

@infiniteluke
Copy link
Member Author

per discussion prepack.io and https://facebook.github.io/jest/ are better examples. We'll keep the website super simple since emdaer is not a big project.

@infiniteluke
Copy link
Member Author

Going to merge this and take care of design changes in a separate branch

@infiniteluke infiniteluke merged commit ac88ad3 into site Nov 20, 2017
@infiniteluke infiniteluke deleted the share-content branch November 20, 2017 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants